Skip to content

fix(windows): add update property to remote check#16126

Open
rc-swag wants to merge 1 commit into
masterfrom
fix/windows/15433/add-update-propery-remote-check
Open

fix(windows): add update property to remote check#16126
rc-swag wants to merge 1 commit into
masterfrom
fix/windows/15433/add-update-propery-remote-check

Conversation

@rc-swag

@rc-swag rc-swag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This just adds the update property to the HTTP request in the RemoteUpdateCheck call.

Fixes: #15433

Test-bot: skip

This just adds the update property to the HTTP request
in the RemoteUpdateCheck call.

Fixes: #15433
@rc-swag rc-swag requested a review from mcdurdin June 23, 2026 07:15
@rc-swag rc-swag self-assigned this Jun 23, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Jun 23, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Windows
    • Keyman for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for Windows (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (ARM64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x86) - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S32 milestone Jun 23, 2026
@rc-swag rc-swag marked this pull request as ready for review June 23, 2026 07:17

@mcdurdin mcdurdin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

bug(windows): update property for windows update check is not set

2 participants